Resolve checkout config provider name is in conflict with paypal/modu… #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-braintree-core module's config rovider This PR is to resolve conflict in name with config provider which results in fixing Invisible captcha not working with PayflowPro in Magento Commerce
fredden
suggested changes
Aug 11, 2021
| <arguments> | ||
| <argument name="configProviders" xsi:type="array"> | ||
| <item name="recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> | ||
| <item name="paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> |
Member
There was a problem hiding this comment.
It looks like this should be namespaced as magento_recaptcha_config_provider or maybe magento_paypal_recaptcha_config_provider and the provider in paypal/module-braintree-core should be namespaced as paypal_recaptcha_config_provider.
Contributor
There was a problem hiding this comment.
Suggested change
| <item name="paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> | |
| <item name="magento_paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> |
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
Contributor
|
Created issue #307 to track |
ihor-sviziev
suggested changes
Dec 3, 2021
| <arguments> | ||
| <argument name="configProviders" xsi:type="array"> | ||
| <item name="recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> | ||
| <item name="paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> |
Contributor
There was a problem hiding this comment.
Suggested change
| <item name="paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> | |
| <item name="magento_paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve checkout config provider name is in conflict with paypal/module-braintree-core module's config rovider
Description (*)
This PR is to resolve conflict in name with config provider which results in fixing Invisible captcha not working with PayflowPro in Magento Commerce
Fixed Issues (if relevant)
V3 Invisible Captcha not working with Payflopro Payment Method