Skip to content

Resolve checkout config provider name is in conflict with paypal/modu… #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Resolve checkout config provider name is in conflict with paypal/modu… #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ReCaptchaPaypal/etc/frontend/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<type name="Magento\Checkout\Model\CompositeConfigProvider">
<arguments>
<argument name="configProviders" xsi:type="array">
<item name="recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item>
<item name="paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item>
Copy link
Member

@fredden fredden Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this should be namespaced as magento_recaptcha_config_provider or maybe magento_paypal_recaptcha_config_provider and the provider in paypal/module-braintree-core should be namespaced as paypal_recaptcha_config_provider.

Copy link
Contributor

@ihor-sviziev ihor-sviziev Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<item name="paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item>
<item name="magento_paypal_recaptcha_config_provider" xsi:type="object">Magento\ReCaptchaPaypal\Model\CheckoutConfigProvider</item>

</argument>
</arguments>
</type>
Expand Down