Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 :- Inspection for using a block cacheable="false" attribute within default layout #62

Conversation

konarshankar07
Copy link
Contributor

Fixed #29

Expected Result

Warning added in the default.xml
image
Fix is also added if you click on "Remove cacheable attribute" then it will remove the cacheable attribute from the default.xml

Vitaliy Boyko added 2 commits March 29, 2020 18:38
…hpstorm-plugin into inspection-cacheable-false--task-29

� Conflicts:
�	CHANGELOG.md
@VitaliyBoyko VitaliyBoyko merged commit ae40c5f into magento:1.0.0-develop Mar 29, 2020
@konarshankar07 konarshankar07 deleted the inspection-cacheable-false--task-29 branch March 30, 2020 04:51
@VitaliyBoyko VitaliyBoyko added Medium and removed Medium labels Apr 1, 2020
@lenaorobei lenaorobei added Medium and removed Medium labels Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspection for using a block cacheable="false" attribute within default layout
4 participants