Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspection for using a block cacheable="false" attribute within default layout #29

Closed
VitaliyBoyko opened this issue Mar 4, 2020 · 2 comments · Fixed by #62
Closed

Inspection for using a block cacheable="false" attribute within default layout #29

VitaliyBoyko opened this issue Mar 4, 2020 · 2 comments · Fixed by #62
Assignees
@konarshankar07
Labels
good first issue inspection Medium pr created release-1.0.0

Comments

@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Mar 4, 2020 •
edited
Loading

Utilizing cacheable="false" attribute within the default layout makes the whole site uncacheable.
It's needed to warn the user about such an effect.
@VitaliyBoyko VitaliyBoyko changed the title Inspection for using cacheable="false" attribute within default layout Inspection for using a block cacheable="false" attribute within default layout Mar 4, 2020
@konarshankar07
Copy link
Contributor

Hello @VitaliyBoyko
Can I work on this ticket?
Thanks

@VitaliyBoyko
Copy link
Contributor Author

Sure.

@konarshankar07 konarshankar07 mentioned this issue Mar 29, 2020
Merged
VitaliyBoyko pushed a commit that referenced this issue Mar 29, 2020
Merge pull request #62 from konarshankar07/inspection-cacheable-false…
ae40c5f 
…--task-29

#29 :- Inspection for using a block cacheable="false" attribute within default layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konarshankar07 konarshankar07

Labels
good first issue inspection Medium pr created release-1.0.0
Projects
None yet
Milestone
No milestone
2 participants
@VitaliyBoyko @konarshankar07