Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2491: Prevent URN map generation during indexing. #2499

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).
- Compatibility with PhpStorm/IntelliJ 2025.* [#2495](https://github.com/magento/magento2-phpstorm-plugin/pull/2495)
- "Copy Path/Reference" does not show the preview value [#2497](https://github.com/magento/magento2-phpstorm-plugin/pull/2497)
- Must not start write action from within read action in the other thread [#2498](https://github.com/magento/magento2-phpstorm-plugin/pull/2498)
- URN map generation during indexing [#2499](https://github.com/magento/magento2-phpstorm-plugin/pull/2499)

## 2025.0.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import com.intellij.notification.NotificationGroupManager;
import com.intellij.notification.NotificationType;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.project.DumbService;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.PsiDirectory;
Expand Down Expand Up @@ -46,17 +47,31 @@ public RegenerateUrnMapListener(final @NotNull Project project) {
* @param event MouseEvent
*/
@Override
@SuppressWarnings("PMD.UseNotifyAllInsteadOfNotify")
public void mouseClicked(final MouseEvent event) {
final ExternalResourceManager manager =
ExternalResourceManager.getInstance();
final PsiManager psiManager = PsiManager.getInstance(project);
final MagentoComponentManager componentManager =
MagentoComponentManager.getInstance(project);
if (DumbService.getInstance(project).isDumb()) {
NotificationGroupManager.getInstance()
.getNotificationGroup("Magento Notifications")
.createNotification(
"URN map generation unavailable",
"Indexing is in progress."
+ " Please wait for it to complete"
+ " before running URN mapping generation.",
NotificationType.WARNING
)
.notify(project);
return;
}

ApplicationManager.getApplication().runWriteAction(
new Runnable() {
@Override
public void run() {
final PsiManager psiManager = PsiManager.getInstance(project);
final MagentoComponentManager componentManager =
MagentoComponentManager.getInstance(project);
final ExternalResourceManager manager =
ExternalResourceManager.getInstance();
final Collection<VirtualFile> xsdFiles
= FilenameIndex.getAllFilesByExt(project, "xsd");
final Collection<MagentoComponent> components
Expand Down
Loading