2491: Prevent URN map generation during indexing. #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check to avoid URN map generation when the project is in indexing (dumb) mode. A warning notification is shown to inform users that they need to wait until indexing is complete. This prevents potential errors or performance issues.
Updated functionality to skip URN map generation while the project is indexing. This helps avoid potential errors and enhances performance stability. A warning notifies users to wait until indexing finishes.
…ssage-that-indexing-in-process # Conflicts: # CHANGELOG.md
Refactored notification text formatting for clarity and consistency. This ensures users are properly informed to wait until indexing is complete before generating URN maps. Enhances user guidance and prevents unwanted actions during indexing.
Moved ExternalResourceManager initialization into the runnable to prevent execution during indexing. This ensures better stability and avoids potential premature resource access.
Moved PsiManager and MagentoComponentManager initialization into the runnable to delay their usage until the appropriate execution context. Added a suppression for PMD warning to ensure clarity and maintain compatibility with standards.
VitaliyBoyko
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to avoid URN map generation when the project is in indexing (dumb) mode. A warning notification is shown to inform users that they need to wait until indexing is complete. This prevents potential errors or performance issues.
Description (*)
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)