Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspection for possible observer name duplication #27

Closed
VitaliyBoyko opened this issue Mar 3, 2020 · 1 comment
Closed

Inspection for possible observer name duplication #27

VitaliyBoyko opened this issue Mar 3, 2020 · 1 comment

Comments

@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Mar 3, 2020

We need to implement a check in a purpose to avoid accidentally overriding an observer.

Acceptance criteria [case warnig]:
Module_Module1 observer:

<event name="sales_order_save_before">
        <observer name="foo" instance="Bar"/>
    </event>

Module_Module2 observer:

<event name="sales_order_save_before">
        <observer name="foo" instance="Bar2"/>
    </event>

As a result, we need to show the warning like "The observer might override another observer. In case you do want to override the observer, please disable the original one and introduce the new one with the unique name".

@VitaliyBoyko VitaliyBoyko changed the title Implement observer name duplication check Implement observer name duplication inspection Mar 3, 2020
@VitaliyBoyko VitaliyBoyko changed the title Implement observer name duplication inspection Inspection for possible observer name duplication Mar 4, 2020
@VitaliyBoyko VitaliyBoyko self-assigned this Mar 18, 2020
@vasilii-b
Copy link

Hi @VitaliyBoyko,
May I work on this?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants