-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line Marker. Navigation between original and override observers. #38
Comments
Could you explain more with some example? |
@lbajsarowicz
You replaces the implementation for the frontend area in the second module (Second_Module/etc/frontend/events.xml).
The main idea is to visualize that an observer is overridden because it could be done by accident. (It's from real life, believe me 😄) Also, I'm working on inspection duplicated names for the same area: #27. However, for different areas, an inspection is not an applicable option as an observer could be overridden intentionally as well and adding Thank you for your interest :) |
And the case with the same area override using sequences should be covered by line markers as well. |
Well, I've overthought this one once again. Using line marker here seems to be overhead. Override an observer using an observer name is not a good practice. It is better to show the error message. |
Line Markers between original and overridden observers (with the same name and the same event).
The text was updated successfully, but these errors were encountered: