Skip to content

Quick Fix: PHP's max() requires at least 1 argument #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Quick Fix: PHP's max() requires at least 1 argument #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Magento/FunctionalTestingFramework/Module/MagentoWebDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,10 @@ private function notifyCronFinished(array $cronGroups = [])
*/
private function getLastCronExecution(array $cronGroups = [])
{
if (empty($this->cronExecution)) {
return 0;
}

if (empty($cronGroups)) {
return (int)max($this->cronExecution);
}
Expand Down Expand Up @@ -1060,7 +1064,7 @@ public function getSecret($key)
/**
* Waits proper amount of time to perform Cron execution
*
* @param string $cronGroups
* @param array $cronGroups
* @param integer $timeout
* @param string $arguments
* @return string
Expand Down