Skip to content

Quick Fix: PHP's max() requires at least 1 argument #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Quick Fix: PHP's max() requires at least 1 argument #573

merged 1 commit into from
Feb 4, 2020

Conversation

lbajsarowicz
Copy link
Contributor

Description

The issue with [PHPUnit\Framework\Exception] max(): Array must contain at least one element appears only when no groups provided. That's why I return 0 when there's no entry for $this->cronExecution

Fixed Issues (if relevant)

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Feb 4, 2020
@lbajsarowicz lbajsarowicz changed the base branch from develop to master February 4, 2020 17:23
@okolesnyk okolesnyk self-requested a review February 4, 2020 17:54
@coveralls
Copy link

coveralls commented Feb 4, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 50.994% when pulling 7560bc3 on lbajsarowicz:fix/magentocron-no-group-provided into c589521 on magento:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 52.492% when pulling 7560bc3 on lbajsarowicz:fix/magentocron-no-group-provided into c589521 on magento:master.

@okolesnyk okolesnyk merged commit 3ccf894 into magento:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk okolesnyk approved these changes

Assignees
No one assigned
Labels
Partner: Mediotype partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbajsarowicz @coveralls @okolesnyk @magento-engcom-team