AC-1100 Catch badly put newlines in LESS files #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliseacornejo
previously approved these changes
Sep 3, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
sivaschenko
requested changes
Sep 3, 2021
There was a problem hiding this comment.
Thanks for the fix @svera ! Please see my comments.
Also, can you please add more information to the phpdoc, particularly it would be great to have a better description for what is happening in the needValidateSpaces function
m2-community-project
bot
added
Progress: changes requested
Progress: review
and removed
Progress: approved
Progress: changes requested
labels
sivaschenko
approved these changes
Sep 3, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch newlines in the middle of a style definition and throw an error if any.
Resolves #242