Skip to content

Catch badly put newlines in LESS files. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svera opened this issue Aug 31, 2021 · 1 comment · Fixed by #258
Closed

Catch badly put newlines in LESS files. #242

svera opened this issue Aug 31, 2021 · 1 comment · Fixed by #258
Assignees
Labels
enhancement Improvements to existing rules Progress: done

Comments

@svera
Copy link
Contributor

svera commented Aug 31, 2021

Description

Newlines existing in the middle of a style definition for LESS files should be catch. Currently, Magento2/Sniffs/Less/ColonSpacingSniff.php has this checking in place but it is not working, as PHPCS strips newlines that goes in the middle of a sentence.

Expected behavior

Being able to catch the following case

.foo {
  bar:
          'xyz';
}

Benefits

An incorrect LESS formatting would be catch

Additional information

@svera svera added the enhancement Improvements to existing rules label Aug 31, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 31, 2021

Hi @svera. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing rules Progress: done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant