MAGECLOUD-4847: Issues caused by MC-21696 hot fix from ece-tools patches #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftedreality
suggested changes
Dec 16, 2019
patches.json
Outdated
| }, | ||
| "Catalog Product pagination does not work on Elasticsearch 6.x": { | ||
| "2.3.3": "MC-21696__fix_broken_pagination_on_ES6__2.3.3.patch" | ||
| "2.3.3": "MAGECLOUD-4847__Elasticsearch_and_products_display_fix__2.3.3.patch" |
Member
There was a problem hiding this comment.
We mostly use lowercase for patches, let's keep the same naming convention here
shiftedreality
approved these changes
Dec 17, 2019
shiftedreality
added
Progress: review
arhiopterecs
approved these changes
Dec 18, 2019
Collaborator
|
QA approved |
magento-cicd2
pushed a commit
that referenced
this pull request
Dec 9, 2020
mmansoor-magento
pushed a commit
that referenced
this pull request
Dec 10, 2020
andriyShevtsov
pushed a commit
that referenced
this pull request
Sep 8, 2025
andriyShevtsov
pushed a commit
that referenced
this pull request
Sep 8, 2025
andriyShevtsov
pushed a commit
that referenced
this pull request
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Existed patch for 2.3.3 - MC-21696, did not solve whole problem with ES and it causes another bug.
Instead of this patch was created new one based on 2 fixes from 2.3.4-develop branch:
Manual testing scenarios
Contribution checklist