MAGECLOUD-4884: Update PageBuilder Patches for RCE #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshmyheliuk
reviewed
Dec 18, 2019
| @@ -0,0 +1,1358 @@ | |||
| diff -Nuar a/vendor/magento/module-page-builder/Controller/Adminhtml/Stage/Preview.php b/vendor/magento/module-page-builder/Controller/Adminhtml/Stage/Preview.php | |||
| new file mode 100644 | |||
| index 000000000..be64e560d | |||
Contributor
There was a problem hiding this comment.
This is not critical but it would be nice to remove indexes from new patches, we did this in all patches.
oshmyheliuk
previously approved these changes
Dec 18, 2019
|
@billygilbert please fix conflict. |
YPyltiai
reviewed
Jan 3, 2020
patches.json
Outdated
| "2.3.2": "MDVA-22979__fix_pagebuilder_module__2.3.2.patch" | ||
| "2.3.1": "PB-319__fix_pagebuilder_module__2.3.1.patch", | ||
| "2.3.2": "PB-320__fix_pagebuilder_module__2.3.2.patch", | ||
| ">=2.3.2-p1 <=2.3.2-p2": "PB-322__fix_pagebuilder_module__2.3.2-p1.patch", |
There was a problem hiding this comment.
In other patches we were using <2.3.3 instead of <=2.3.2-p2. The reason is - if eventually it is re-packed for some reason, the patch needs to keep applying.
|
@davemacaulay, please review |
oshmyheliuk
previously approved these changes
Jan 6, 2020
shiftedreality
previously approved these changes
Jan 6, 2020
billygilbert
dismissed stale reviews from shiftedreality and oshmyheliuk
via
a86e5b9
oshmyheliuk
approved these changes
Jan 7, 2020
shiftedreality
approved these changes
Jan 7, 2020
davemacaulay
approved these changes
Jan 7, 2020
Collaborator
|
QA approved |
mmansoor-magento
pushed a commit
that referenced
this pull request
Dec 10, 2020
andriyShevtsov
pushed a commit
that referenced
this pull request
Sep 8, 2025
andriyShevtsov
pushed a commit
that referenced
this pull request
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://magento2.atlassian.net/browse/MAGECLOUD-4884
Manual testing scenarios
PB-319__fix_pagebuilder_module_2.3.1.patchis appliedPB-320__fix_pagebuilder_module__2.3.2.patchis appliedPB-322__fix_pagebuilder_module__2.3.2-p1.patchis appliedPB-322__fix_pagebuilder_module__2.3.2-p1.patchis appliedPB-323__fix_pagebuilder_module__2.3.3.patchis appliedMDVA-22979patches are never appliedContribution checklist