Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nidsharm/react-javascript-to-typescript-transform
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 82be52d
Choose a base ref
...
head repository: lyft/react-javascript-to-typescript-transform
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3b91d88
Choose a head ref
  • 19 commits
  • 97 files changed
  • 5 contributors

Commits on Jan 20, 2018

  1. Fix link to VSCode plugin

    mohsen1 authored Jan 20, 2018
    Configuration menu
    Copy the full SHA
    cff8772 View commit details
    Browse the repository at this point in the history
  2. Update TypeScript to 2.6 (lyft#16)

    * ts 2.6
    
    * fix: TransformerFactory type should be SourceFile rather than Node
    
    TypeScript will complain about:
    "Type 'Node' is not assignable to type 'SourceFile'."
    
    * fix: use lodash to fix type error
    
    ts.NodeArray now is ReadonlyArray, helper functions should accept
    ArrayLike arguments.
    
    * flatten function structure
    
    * fix ts type mismatch
    
    * update test output
    
    * replace helpers.isKind with ts.isXXX
    
    * namespace import lodash & use lodash.find directly
    vincentbel authored and mohsen1 committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    aaf86ed View commit details
    Browse the repository at this point in the history
  3. support more prop types (lyft#19)

    vincentbel authored and mohsen1 committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    45c5dca View commit details
    Browse the repository at this point in the history
  4. Use yarn (lyft#20)

    * Use yarn
    
    * travis
    mohsen1 authored Jan 20, 2018
    Configuration menu
    Copy the full SHA
    ca89c56 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    623cffe View commit details
    Browse the repository at this point in the history
  6. Support stateless component (lyft#23)

    * remove hoist transform
    
    * support stateless component
    
    * don't make type alias if prop or state types are empty
    
    * fix: should only transform current source file
    vincentbel authored and mohsen1 committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    f84e4e8 View commit details
    Browse the repository at this point in the history
  7. Fix lint

    mohsen1 committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    394ae32 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2018

  1. Configuration menu
    Copy the full SHA
    e2bfbc0 View commit details
    Browse the repository at this point in the history
  2. remove prop types import (lyft#29)

    vincentbel authored and mohsen1 committed Jan 21, 2018
    Configuration menu
    Copy the full SHA
    3ab7758 View commit details
    Browse the repository at this point in the history
  3. Fix typo

    mohsen1 committed Jan 21, 2018
    Configuration menu
    Copy the full SHA
    1204fea View commit details
    Browse the repository at this point in the history
  4. Pretty print using prettier (lyft#25)

    * Pretty print using prettier
    
    * Remove yarn log
    
    * Use CLI input for prettier config
    
    * pass config in test
    mohsen1 authored Jan 21, 2018
    Configuration menu
    Copy the full SHA
    95f308b View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2018

  1. v1.3.0

    mohsen1 committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    76ce5b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Configuration menu
    Copy the full SHA
    23cdac4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e17c1b View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2018

  1. Keep other static class members, such as defaultProps (lyft#36)

    * Add test for defaultProps
    
    * Check if the name == "propTypes", not != " propTypes"
    
    * More ways of getting the class member name (hacky)
    
    * Check if we're an identifier; if we are we can just always use name.escapedText
    
    * Use ts.isIdentifier helper function instead of direct comparison on .kind
    Athena Yao authored and mohsen1 committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    a2338d9 View commit details
    Browse the repository at this point in the history
  2. v1.4.0

    Mohsen Azimi committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    3f11a66 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2018

  1. Update README.md

    mohsen1 authored Apr 7, 2018
    Configuration menu
    Copy the full SHA
    abbbb57 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. Update dependencies (lyft#42)

    * Update dependencies
    mohsen1 authored May 19, 2018
    Configuration menu
    Copy the full SHA
    9bd8777 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2018

  1. Safety/QOL fixes (lyft#39)

    * Build prettier options only once
    
    * Use a temporary file for the transformation
    
    * Add --ignore-prettier-errors option
    
    * Add --keep-*-files options for easier debugging
    
    * Exit with error code 1 when there were compilation errors
    
    * Fix multiple file/glob parameters
    
    Refs lyft#31
    
    Refs lyft#37
    
    * Add progress message
    akx authored and mohsen1 committed May 20, 2018
    Configuration menu
    Copy the full SHA
    3b91d88 View commit details
    Browse the repository at this point in the history
Loading