Skip to content

LCA implementation (fixes #89) #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 15, 2019
Merged

LCA implementation (fixes #89) #91

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a286327
Create solution file
amahdy Oct 14, 2019
94ef050
Move to correct folder
amahdy Oct 14, 2019
d0e76c8
Add the algorithm
amahdy Oct 14, 2019
7cc8489
Add a test case
amahdy Oct 14, 2019
950a021
Fix test case
amahdy Oct 14, 2019
bd37bb0
Fix test by adding missing arguments
amahdy Oct 14, 2019
76f3214
Move to inside BST folder
amahdy Oct 15, 2019
8801d14
Move to inside BST folder
amahdy Oct 15, 2019
c07991a
Add more tests and use BST class
amahdy Oct 15, 2019
5a83abb
Fix variable declaration
amahdy Oct 15, 2019
b2565c4
Update reference
amahdy Oct 15, 2019
bb9e4bf
Match naming used in BST
amahdy Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update reference
  • Loading branch information
@amahdy
amahdy authored Oct 15, 2019
commit b2565c4289e7779d7328248012e0ab28d4e02ec3
6 changes: 3 additions & 3 deletions src/_DataStructures_/Trees/BinarySearchTree/lowest-common-ancestor/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ describe('LCA', () => {
bst.add(10);

it('Should return 12', () => {
expect(lca(bst.root, 10, 14).data).toEqual(12);
expect(lca(bst.root, 10, 14).value).toEqual(12);
});

it('Should return 8', () => {
expect(lca(bst.root, 14, 8).data).toEqual(8);
expect(lca(bst.root, 14, 8).value).toEqual(8);
});

it('Should return 20', () => {
expect(lca(bst.root, 10, 22).data).toEqual(20);
expect(lca(bst.root, 10, 22).value).toEqual(20);
});
});