Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCA implementation (fixes #89) #91

Merged
merged 12 commits into from
Oct 15, 2019
Merged

LCA implementation (fixes #89) #91

merged 12 commits into from
Oct 15, 2019

Conversation

amahdy
Copy link
Contributor

@amahdy amahdy commented Oct 14, 2019

No description provided.

@amahdy
Copy link
Contributor Author

amahdy commented Oct 14, 2019

Fixes #89

Copy link
Member

@TheSTL TheSTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required:

  • Test cases should be simple to read. For example: instead of using this {"left":{"left":{"data":4},"right":{"left":{"data":10},"right":{"data":14},"data":12},"data":8},"right":{"data":22},"data":20} you should create a bst tree . Bst file location - BST
  • Can you move your folder to here BinarySearchTree

@amahdy
Copy link
Contributor Author

amahdy commented Oct 15, 2019

You might be wondering why too many changes :) I do everything here on the Github online, no single local file / editors ..etc. Anyway, now it's all set!

@amahdy amahdy requested a review from TheSTL October 15, 2019 18:23
Copy link
Member

@TheSTL TheSTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahdy for PR 👍

@TheSTL TheSTL merged commit 1387eef into knaxus:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants