Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for bug #61 #118

Closed
wants to merge 300 commits into from
Closed

Fixes for bug #61 #118

wants to merge 300 commits into from

Conversation

k88manish
Copy link
Contributor

  • Added test cases for error cases
  • Handled invalid expression
  • ESLint error fixes

ashokdey and others added 30 commits September 8, 2019 12:52
@ashokdey
--fix : comment
fc38e63
@ashokdey
--update: initial implementation
db6f79b
@ashokdey
--fix: edge case of upper case alphabet
f413b65
@ashokdey
--fix: missing case for -ve new index
aa610aa
@ashokdey
--update: final implementation
fc8170f
@ashokdey
--fix: spell fix
73a49c5
@ashokdey
--update: max2 initialization, return false if no pair found
5dfaf81
@ashokdey
Merge pull request #9 from knaxus/fix-sum-upto-N
6a3e32c 
Minor fixes
@ashokdey
--update: get pair of index for two numbers sum to N
552bf00
@ashokdey
--update: replaced indexof with Map(), throw error on missing arguments
b68aa58
@ashokdey
--update: added fibonacci
436293a
@ashokdey
--update: added optimized fibonacci using cache
46dcf70
@ashokdey
--update: 32-bit signed int reversal
1123481
Added get-maze-path problem and added complexities in previous problems
9d82c02
Merge branch 'branch1' of https://github.com/navneet15/problem-solvin…
0e71035 
…g-javascript into branch1
@ashokdey
--fix: removed outdated files
d40713f
@ashokdey
--fix-conflict: got files from master
4a93ef6
@ashokdey
Merge pull request #10 from knaxus/classics
b47e5c3 
Classics
@ashokdey
Merge pull request #6 from navneet15/branch1
cddea0f 
Permutation & Subsequence of String and all paths of M x N grid
@ashokdey
update: Fibonacci using tabular method
e960f8e
@ashokdey
Merge pull request #12 from knaxus/classics
14f950a 
update: Fibonacci using tabular method
@ashokdey
update: new problem added
e68c9d0
@ashokdey
update: cleanup and comments
0758df4
@ashokdey
update: reduced a comparision on every iteration
7ab5452
@ashokdey
fix: comment
20d20c7
@ashokdey
Merge pull request #13 from knaxus/problems
4858018 
update: new problem added
@ashokdey
update: table of contents in README
55180df
@ashokdey
update: complete TOC, change in repo name
e62c31f
@ashokdey
Merge pull request #14 from knaxus/readme
4f5a2ad 
Readme
@TheSTL
--update : add A* algo
499b78f
ashokdey and others added 15 commits October 18, 2019 13:46
@ashokdey
Create LICENSE
13f3806
@ashokdey
Create CONTRIBUTING.md
b2922d3
@ashokdey
Update README.md
ead7b22
@TheSTL
Merge pull request #102 from knaxus/ll
aa21c93 
Changes in Linked Lists
@TheSTL
Merge pull request #100 from ngittlen/master
84cb982 
Added tests for the A* algorithm and cleaned up A* directories
@ashokdey
update: TrieNode, insert() in Trie
282294b
@ashokdey
update: trie search()
164d39c
@ashokdey
update: entry in readme
427349c
@TheSTL
Merge pull request #104 from knaxus/trie
9d3abc8 
Trie - tree based data structure
@sanyamdogra
change: the data part should be named as my_data
349227c
@sanyamdogra
revert: got back to initial naming and added a marker
9b952bd 
Added comment so that no one changes the Node class
@ashokdey
Merge pull request #109 from sanyamdogra/master
3ecfecb 
change: the data part should be named as my_data
@theIYD
Add Test for Binary Tree Preorder Traversal
855e533
@TheSTL
Merge pull request #111 from theIYD/master
bfb659f 
Add Test for Binary Tree Preorder Traversal
Fixes for bug #61
f30d448 
- Added test cases for error cases
- Handled invalid expression
- ESLint error fixes
@k88manish
Copy link
Contributor Author

Hi @ashokdey, @TheSTL. I have made the fixes for #61. Please review it help me to merge it.

@k88manish k88manish mentioned this pull request Oct 20, 2019
Closed
@TheSTL
Copy link
Member

TheSTL commented Oct 20, 2019

@k88manish We are not getting your commit properly . Please setup you git properly.
image

@TheSTL
Copy link
Member

TheSTL commented Oct 20, 2019

When stack is not empty or expression is not there is should throw an error instead of returning a string. You can check this problem to get idea and then write test case accordingly - fibonacci

@k88manish
Copy link
Contributor Author

Hi @TheSTL, Thanks for reviewing it. I have made the changes to replace string message with throw error. Can you please review it again?

@TheSTL
Copy link
Member

TheSTL commented Oct 21, 2019

@k88manis

@k88manish We are not getting your commit properly . Please setup you git properly.
image

Not getting your commit.
Please fix this

@TheSTL
Copy link
Member

TheSTL commented Oct 22, 2019

@k88manish I think it will work commits-are-not-getting-linked-with-github-account .
And please also check this issue for your other PRs

@k88manish
Copy link
Contributor Author

closing this pull request because the Author information is not correct. Will open a new one

@k88manish k88manish closed this Oct 22, 2019
@k88manish k88manish deleted the postfix-bug-61 branch October 22, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix changes-requested good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.