Classics #10
Merged
Classics #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSTL
reviewed
Sep 8, 2019
| } | ||
|
|
||
| // determine the new index | ||
| const currentIndex = alphabets.indexOf(currentCharacter); |
There was a problem hiding this comment.
Try to use Map to find index of currentCharacter instead of indexOf.
- With indexOf complexity will be O(n*26).
- With Map complexity will be O(n).
There was a problem hiding this comment.
@TheSTL, any example snippet would be helpful.
TheSTL
approved these changes
Sep 8, 2019
TheSTL
requested changes
Sep 8, 2019
TheSTL
reviewed
Sep 10, 2019
| Output: 0 // overflows | ||
| Note: | ||
| Assume we are dealing with an environment which could only | ||
| store integers within the 32-bit signed integer range: [−2^31, 2^31 − 1]. |
There was a problem hiding this comment.
Try to solve problem for input > 2^31 -1 .
It is also possible.
There was a problem hiding this comment.
Yes, it can be done, I tried that before adding the return 0; block. I simply posted the solution for one of the coding challenge platforms.
Deleted the outdated files, then pulled from the master 👍 |
TheSTL
approved these changes
Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new folder containing a few of the classic problems like:
.
.
.
etc