Merge from NetFlix #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All unit tests now pass.
Lift and Observer+Subscription
1. OperatorViewClick 2. OperatorEditTextInput 3. OperatorCompoundButtonInput
Careful With That Global Search And Replace, Eugene.
Fix problem with Observable.create()
repair anchors in links to RxJava wiki in javadocs
-> Restore Observer interface -> Subscriber implements Observer, Subscription
improve switchOnNext description in javadocs
- rxjava-core is passing all unit tests - other modules are failing
Observer + Subscriber
Add Subscription.isUnsubscribed()
Preparing for release of 0.17
Scheduler Outer/Inner [Preview]
…Exception.attachCallingThreadStack
Also make tests capable of failing with timeouts. Before the constructor would immediately go into an infinite loop and hang the tests.
Fix CompositeException
- Use new lift operator implement and non-blocking synchronization approach. - I have had the concurrency model reviewed by some colleagues and all unit tests are passing but further review is justified and welcome.
Make Subscriptions of SwingObservable thread-safe
Rewrite OperationObserveFromAndroidComponent to OperatorObserveFromAndro...
I found a way to pass the value down the chain without wrapping the Throwable. This way it only shows up if using `onErrorFlatMap` or looking at the final cause on any given Throwable. A final cause will be added so Throwables end up like this: java.lang.RuntimeException: Forced Failure at rx.operators.OperatorMapTest$5.call(OperatorMapTest.java:164) at rx.operators.OperatorMapTest$5.call(OperatorMapTest.java:1) at rx.operators.OperatorMap$1.onNext(OperatorMap.java:54) at rx.operators.OnSubscribeFromIterable.call(OnSubscribeFromIterable.java:43) at rx.operators.OnSubscribeFromIterable.call(OnSubscribeFromIterable.java:1) at rx.Observable$2.call(Observable.java:269) at rx.Observable$2.call(Observable.java:1) at rx.Observable$2.call(Observable.java:269) at rx.Observable$2.call(Observable.java:1) at rx.Observable.subscribe(Observable.java:7022) at rx.Observable.subscribe(Observable.java:6945) at rx.operators.OperatorMapTest.testMapWithError(OperatorMapTest.java:177) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) at org.junit.runners.ParentRunner.run(ParentRunner.java:300) at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:50) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197) Caused by: rx.exceptions.OnErrorThrowable$OnNextValue: OnError while emitting onNext value: fail at rx.exceptions.OnErrorThrowable.decorate(OnErrorThrowable.java:55) at rx.operators.OperatorMap$1.onNext(OperatorMap.java:56) ... 33 more Note the final cause: Caused by: rx.exceptions.OnErrorThrowable$OnNextValue: OnError while emitting onNext value: fail Then when onErrorFlatMap is used, it retrieves that final cause out to create an OnErrorThrowable so people don't have to go fetch it from the cause chain.
onErrorFlatMap + OnErrorThrowable
…rror-handling Handle illegal errors thrown from plugin
GroupBy Unit Test from #900
Fixed NullPointerException that may happen on timeout
Allow setting different default schedulers for use by system.
Scheduler.Recurse fields should be private
Merge: Unsubscribe Completed Inner Observables
Clearer semantic naming.
RxJavaSchedulers Plugin
Use groupBy.map instead.
This enforces the convention of using `Schedulers.*` and then makes the RxJavaDefaultSchedulers plugin more reliable.
- remove the Func0 factory signature for Scheduler creation.
Scheduler Plugin Refactor
Remove groupBy with selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.