Add Subscription.isUnsubscribed()

[benjchristensen]

With the new model of injecting Subscription into functions for synchronous loops to check isUnsubscribed() it now makes sense for this to be on the interface of all Subscription implementations.

[cloudbees-pull-request-builder]

RxJava-pull-requests #717 SUCCESS
This pull request looks good

[headinthebox]

Thanks Ben, as you know, I wanted this change for a long time!

On Sat, Feb 1, 2014 at 1:48 AM, Ben Christensen notifications@github.comwrote:

With the new model of injecting Subscription into functions for
synchronous loops to check isUnsubscribed() it now makes sense for this

to be on the interface of all Subscription implementations.

You can merge this Pull Request by running

git pull https://github.com/benjchristensen/RxJava subscription-isunsubscribed

Or view, comment on, or merge it at:

#796
Commit Summary

• Add Subscription.isUnsubscribed()

File Changes

• M
  language-adaptors/rxjava-groovy/src/examples/groovy/rx/lang/groovy/examples/RxExamples.groovyhttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-0(7)
• M
  language-adaptors/rxjava-groovy/src/test/groovy/rx/lang/groovy/ObservableTests.groovyhttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-1(7)
• M
  language-adaptors/rxjava-scala/src/main/scala/rx/lang/scala/Subscription.scalahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-2(2)
• M
  rxjava-contrib/rxjava-android/src/main/java/rx/operators/OperationObserveFromAndroidComponent.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-3(8)
• M rxjava-core/src/main/java/rx/Subscription.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-4(2)
• M rxjava-core/src/main/java/rx/operators/ChunkedOperation.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-5(14)
• M rxjava-core/src/main/java/rx/operators/OperationBuffer.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-6(5)
• M rxjava-core/src/main/java/rx/operators/OperationConcat.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-7(8)
• M rxjava-core/src/main/java/rx/operators/OperationGroupJoin.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-8(6)
• M
  rxjava-core/src/main/java/rx/operators/OperationMergeDelayError.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-9(38)
• M rxjava-core/src/main/java/rx/operators/OperationMulticast.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-10(7)
• M
  rxjava-core/src/main/java/rx/operators/OperationOnErrorResumeNextViaFunction.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-11(8)
• M
  rxjava-core/src/main/java/rx/operators/OperationOnErrorResumeNextViaObservable.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-12(8)
• M
  rxjava-core/src/main/java/rx/operators/OperationOnErrorReturn.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-13(8)
• M
  rxjava-core/src/main/java/rx/operators/OperationOnExceptionResumeNextViaObservable.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-14(8)
• M rxjava-core/src/main/java/rx/operators/OperationReplay.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-15(5)
• M rxjava-core/src/main/java/rx/operators/OperationSkipUntil.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-16(6)
• M rxjava-core/src/main/java/rx/operators/OperationSubscribeOn.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-17(7)
• M rxjava-core/src/main/java/rx/operators/OperationZip.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-18(6)
• M
  rxjava-core/src/main/java/rx/operators/SafeObservableSubscription.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-19(5)
• M
  rxjava-core/src/main/java/rx/schedulers/CurrentThreadScheduler.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-20(5)
• M rxjava-core/src/main/java/rx/schedulers/DiscardableAction.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-21(5)
• M rxjava-core/src/main/java/rx/schedulers/ExecutorScheduler.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-22(5)
• M rxjava-core/src/main/java/rx/schedulers/TestScheduler.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-23(9)
• M
  rxjava-core/src/main/java/rx/subjects/SubjectSubscriptionManager.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-24(9)
• M
  rxjava-core/src/main/java/rx/subscriptions/RefCountSubscription.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-25(5)
• M rxjava-core/src/main/java/rx/subscriptions/Subscriptions.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-26(45)
• M rxjava-core/src/test/java/rx/operators/OperationConcatTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-27(23)
• M
  rxjava-core/src/test/java/rx/operators/OperationMaterializeTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-28(10)
• M
  rxjava-core/src/test/java/rx/operators/OperationMergeDelayErrorTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-29(51)
• M
  rxjava-core/src/test/java/rx/operators/OperationSynchronizeTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-30(5)
• M rxjava-core/src/test/java/rx/operators/OperationUsingTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-31(5)
• M rxjava-core/src/test/java/rx/operators/OperatorMergeTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-32(41)
• M rxjava-core/src/test/java/rx/operators/OperatorTakeTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-33(5)
• M
  rxjava-core/src/test/java/rx/subscriptions/CompositeSubscriptionTest.javahttps://github.com/Add Subscription.isUnsubscribed() #796/files#diff-34(50)

Patch Links:

• https://github.com/Netflix/RxJava/pull/796.patch
• https://github.com/Netflix/RxJava/pull/796.diff

Reply to this email directly or view it on GitHubhttps://github.com//pull/796
.