Fixed edge case handling in RecordEpisode wrapper #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems to be an expected behavior, since the observation after resetting the environment is a part of the trajectory. Can you elaborate on the cases that cause inconvenience when you want to ignore observations after reset? |
* rename `reorder_trajectories` to `clean_on_close` * `clean_on_close` is set to True by default * handle empty action and done
Jiayuan-Gu
force-pushed
the
fix-record-wrapper
branch
from
df1da40 to
49fa922
Compare
Jiayuan-Gu
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to empty action history, the current
RecordEpisodewrapper will throw out an error when a user resets twice under the default setting, as_episode_datais not empty. The same would also happen ifflush_trajectory()is manually called right after the reset whensave_on_resetis turned off.