Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimentally support KuafuRenderer #24

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Experimentally support KuafuRenderer #24

merged 1 commit into from
Sep 7, 2022

Conversation

Jiayuan-Gu
Copy link
Contributor

https://sapien.ucsd.edu/docs/2.1/tutorial/rendering/raytracing_renderer.html

KuafuRenderer only supports "Color" texture, and thus I only support getting RGB images for KuafuRenderer now. Besides, sapien.utils.Viewer does not support KuafuRenderer. In brief, only partial, offline usage is supported now.

@Jiayuan-Gu Jiayuan-Gu linked an issue Sep 5, 2022 that may be closed by this pull request
@Jiayuan-Gu Jiayuan-Gu requested a review from fbxiang September 5, 2022 18:46
@fbxiang
Copy link
Contributor

fbxiang commented Sep 7, 2022

Code is good, but it seems to also add gt_segmentation feature, so you can use a better commit message?

@Jiayuan-Gu
Copy link
Contributor Author

Code is good, but it seems to also add gt_segmentation feature, so you can use a better commit message?

I think gt_segmentation feature is added before. I just change the internal name in fact. However, I can update the commit message.

* `enable_gt_seg` is renamed to `_enable_gt_seg` within `BaseEnv`.
@Jiayuan-Gu Jiayuan-Gu merged commit 787439b into main Sep 7, 2022
@Jiayuan-Gu Jiayuan-Gu deleted the kuafu-renderer branch September 7, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replay demonstration using the raytracing rendering
2 participants