Fix deprecated calls for Python 3.9 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitdb/pack.py
Outdated
| # read stream to array, convert to tuple | ||
| a = array.array('I') # 4 byte unsigned int, long are 8 byte on 64 bit it appears | ||
| a.fromstring(buffer(self._cursor.map(), self._pack_offset, self._pack_64_offset - self._pack_offset)) | ||
| _frombytes(a, buffer(self._cursor.map(), self._pack_offset, self._pack_64_offset - self._pack_offset)) |
There was a problem hiding this comment.
It can be simpler:
a = array.array('I', buffer(self._cursor.map(), self._pack_offset, self._pack_64_offset - self._pack_offset))
Or maybe even use memoryview(self._cursor.map())[self._pack_offset : self._pack_64_offset] instead of buffer(...) (not tested).
Byron
requested changes
Feb 8, 2020
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution, it's very much appreciated.
I have left a few comments and will merge as soon as Python 2 compatibility is removed.
The array methods fromstring/tostring have been deprecated since Python 3.2. Python 3.9 removes them completely. This was discovered when trying to build gitdb package for Fedora 33. https://bugzilla.redhat.com/show_bug.cgi?id=1788660
lubomir
force-pushed
the
py39-deprecations
branch
from
9653f31 to
7729239
Compare
Contributor
Author
|
I updated the code to drop Python 2 compatibility. |
Member
|
Thanks a lot for your contribution! I will cut release v3.0 soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array methods fromstring/tostring have been deprecated since Python 3.2. Python 3.9 removes them completely.
This was discovered when trying to build gitdb package for Fedora 33.
https://bugzilla.redhat.com/show_bug.cgi?id=1788660