Skip to content

array.tostring and fromstring were removed in Python 3.9 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tirkarthi opened this issue Feb 8, 2020 · 3 comments · Fixed by #53
Closed

array.tostring and fromstring were removed in Python 3.9 #54

tirkarthi opened this issue Feb 8, 2020 · 3 comments · Fixed by #53
Labels
acknowledged

Comments

@tirkarthi
Copy link

gitdb/gitdb/test/lib.py

Line 160 in 43e1631

return a.tostring()

gitdb/gitdb/pack.py

Line 413 in 43e1631

a.fromstring(buffer(self._cursor.map(), self._pack_offset, self._pack_64_offset - self._pack_offset))

Ref: python/cpython#17487
@Byron
Copy link
Member

Byron commented Feb 12, 2020

Thanks for letting us know!

Would it be feasible for you to submit a PR with these changes? I would presume it to be easily merged.

@tirkarthi
Copy link
Author

I will submit a PR.

@Harmon758
Copy link
Member

There already is a PR, #53, that resolves this issue.

@Harmon758 Harmon758 linked a pull request Feb 13, 2020 that will close this issue
Fix deprecated calls for Python 3.9 #53
Merged
@Byron Byron closed this as completed in #53 Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecated calls for Python 3.9 lubomir/gitdb
3 participants
@Byron @tirkarthi @Harmon758