fix(tracing): Make unsampled transactions findable on the scope #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
approved these changes
Oct 19, 2020
untitaker
reviewed
Oct 19, 2020
lobsterkatie
changed the title
lobsterkatie
force-pushed
the
kmclb-make-unsampled-transactions-findable
branch
from
22dc506 to
96ea210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when trying to find the transaction on the scope (if any), we look for a span on the scope (which could be the transaction itself, or could be one of its descendants) and grab the first span in its span recorder. This works, but has the disadvantage that it can only find transactions with
sampled = True, since transactions withsampled = Falsedon't have a span recorder.This changes the getter to use the current span's transaction pointer (added in #870) to find the transaction instead.