feat(tracing): Add traces_sampler option
#863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2020
lobsterkatie
force-pushed
the
kmclb-add-tracessampler
branch
from
30b3606 to
a7bbb6e
Compare
lobsterkatie
force-pushed
the
kmclb-add-tracessampler
branch
from
a7bbb6e to
a92b322
Compare
lobsterkatie
changed the title
traces_sampler optiontraces_sampler option
untitaker
approved these changes
Oct 22, 2020
Member
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
just doing a perf review of this since i have no context. I'm just going to trust you with the impl since this since rodolfo is ooo and you already implemented the JS one anyway
untitaker
reviewed
Oct 22, 2020
untitaker
reviewed
Oct 22, 2020
untitaker
reviewed
Oct 22, 2020
lobsterkatie
changed the title
traces_sampler optiontraces_sampler option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
traces_sampleroption to the SDK, allowing dynamic sampling and filtering of transactions, as outlined here.The one piece of that spec that this doesn't yet implement is pulling in default sampling context values from various frameworks/integrations, which will happen in subsequent PRs.