feat(tracing): Add helper functions for new traces_sampler option
#869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-traces-sampler-helpers
branch
5 times, most recently
from
b31a770 to
dab7c37
Compare
untitaker
approved these changes
Oct 21, 2020
lobsterkatie
force-pushed
the
kmclb-traces-sampler-helpers
branch
from
dab7c37 to
554c878
Compare
lobsterkatie
changed the title
traces_sampler optiontraces_sampler option
lobsterkatie
added a commit
that referenced
this pull request
Oct 21, 2020
…869) - A function to determine if tracing is enabled - A function to validate sample rates returned from `traces_sampler` - A `to_json` method in the `Transaction` class building upon the one already in the `Span` class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds (but doesn’t yet use) some helper functions/methods which will be used in the implementation of the new
traces_sampleroption. It includes:traces_samplerto_jsonmethod in theTransactionclass building upon the one already in theSpanclassWhile creating
transaction.to_json, I also removed the unusedclientparameter inspan.to_json.