React scripts layout.ejs optional title param #17078
Closed
+21,437
−30,618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caldogwoods
commented
May 12, 2025
caldogwoods
commented
Added ability to send an optional 'title' param to override the default <title> value.
When using the `--profile` option, there is an error because react-dom is defined twice in the aliases This moves the profile override to the end so it always wins
Fix profiling configuration
add crossorigin to manifest link for geo redirect
* Fix profiling configuration When using the `--profile` option, there is an error because react-dom is defined twice in the aliases This moves the profile override to the end so it always wins * bump travis to use node 14 * add crossorigin to manifest link for geo redirect Co-authored-by: Logan Allred <redbugz@gmail.com> Co-authored-by: Logan Allred <allredlt@familysearch.org>
…of what is provided in eslint-config-frontier-react
…of what is provided in eslint-config-frontier-react
add geodata from snow
better error handling/logging for failed builds
* adding flag to remove isLoggedIn * update package-lock for react script change * correcting change * Update packages/react-scripts/layout/views/layout.ejs * Update packages/react-scripts/layout/views/layout.ejs * looking to skipSessionPrevalidation to set isLoggedIn * stricter equality check for consistency with how we do this everywhere else --------- Co-authored-by: Nick Nielsen <nick.n.nielsen@familysearch> Co-authored-by: Logan Allred <allredlt@familysearch.org>
update proxy list with photos/apiHelper
This reverts commit 47be467.
[Cypress] ignore .map files in node_modules for cypress webpack.
…window variable (#380) * Add REACT_APP_INJECT_STYLES to allow injecting generated styles into window variable * Add script injection from manifest entrypoints * Updating style injection for prod * version bump * Update packages/react-scripts/config/webpack.config.js Co-authored-by: Joey Cozza <joeycozza@gmail.com> * Update packages/react-scripts/package.json Co-authored-by: Joey Cozza <joeycozza@gmail.com> * Update packages/react-scripts/config/webpack.config.js Co-authored-by: Joey Cozza <joeycozza@gmail.com> * Update packages/react-scripts/config/webpack.config.js Co-authored-by: Joey Cozza <joeycozza@gmail.com> * Update packages/react-scripts/config/webpack.config.js Co-authored-by: Joey Cozza <joeycozza@gmail.com> * version change * fix version bump * Simplify env vars; fix plugin variable names * Change hf scripts output to json file * add directory for hf script output files --------- Co-authored-by: Joey Cozza <joeycozza@gmail.com>
for freshCraTemplateUpdate script
[@fs/react-scripts] Add colors for fr-test's jest tests
- Check coverage for combined cypress and jest tests - Show text and text-summary for combined cypress and jest tests and in color
[@fs/react-scripts] Update merged test report command
Add support for emotion in cypress component tests
Support TypeScript Cypress tests in apps
Cypress support for svg images
Read logoHref from snow res.locals for apple-touch-icon for PWAs
|
Hi @caldogwoods! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Woah. 63 files? I just changed one line. I may have to recreate a fresh PR |
|
Que es esto alguien me ayude no entiendo bien esto por favor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.