Support TypeScript Cypress tests in apps #384
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeycozza
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fr-migrating tree-person-r9, cypress was throwing an error when declaring or using a type in a cypress test like so:
I didn't have this issue in ancestors-r9. ancestors-r9 has its own babel config due to the special nature of ancestors-r9. I was able to figure out that the
@babel/preset-typescriptin the babel config is what allowed ancestors-r9 to work with types in its cypress tests and tree-person-r9 not. I was able to test it in tree-person-r9 by directly adding@babel/preset-typescriptas a preset in @fs/react-scripts in tree-person-r9's node modules. This pr makes it official so we can consume it in tree-person-r9.