Skip to content

Convert invalid characters in SVG component name to ASCII #10514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Convert invalid characters in SVG component name to ASCII #10514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf7f56c
Convert invalid characters in SVG component name to ASCII
nvh95 Feb 5, 2021
e7432e4
test: Add test to avoid failed to transform some svg files
nvh95 Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/react-scripts/config/jest/fileTransform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ module.exports = {
const pascalCaseFilename = camelcase(path.parse(filename).name, {
pascalCase: true,
});
const componentName = `Svg${pascalCaseFilename}`;
// Convert invalid character to ASCII number
const pascalCaseValidFilename = pascalCaseFilename
.split('')
.map(char => (/[a-zA-Z0-9_]/.test(char) ? char : char.codePointAt(0)))
.join('');
const componentName = `Svg${pascalCaseValidFilename}`;
return `const React = require('react');
module.exports = {
__esModule: true,
Expand Down
6 changes: 5 additions & 1 deletion packages/react-scripts/fixtures/kitchensink/template/src/features/webpack/SvgInclusion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@

import React from 'react';
import logo from './assets/logo.svg';
import logo2 from './assets/logo@2x.svg';

const SvgInclusion = () => (
<img id="feature-svg-inclusion" src={logo} alt="logo" />
<>
<img id="feature-svg-inclusion" src={logo} alt="logo" />
<img src={logo2} alt="logo" />
</>
);

export default SvgInclusion;
1 change: 1 addition & 0 deletions ...t-scripts/fixtures/kitchensink/template/src/features/webpack/assets/logo@2x.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.