Convert invalid characters in SVG component name to ASCII #10514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvh95
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
@ianschmitz @iansu @mrmckeb @petetnt I just update a test to cover this case. It's great if you guys can give me any feedback. Thanks. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10513
If we import an SVG which filename contains some characters like
@,react-scripts testwill fail. For examplelogo@2x.svg. The reason is whenpackages/react-scripts/config/jest/fileTransform.jstransformslogo@2x.svgto a component with the name ofSvgLogo@2X. It is not a valid component name (or javascript variable).I fix this by converting a character which is non-letter, non-number, non-underscore, into an ASCII number.
So
logo@2x.svgwill be transformed toSVGLogo642Xinstead ofSvgLogo@2X, which is a valid component name