Skip to content

feat(op-deployer): customize etherscan URL from CLI and environment #17674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+20 −6
Open

feat(op-deployer): customize etherscan URL from CLI and environment #17674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions op-deployer/pkg/deployer/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const (
PrivateKeyFlagName = "private-key"
IntentTypeFlagName = "intent-type"
EtherscanAPIKeyFlagName = "etherscan-api-key"
EtherscanUrlFlagName = "etherscan-url"
InputFileFlagName = "input-file"
ContractNameFlagName = "contract-name"
)
Expand Down Expand Up @@ -104,6 +105,12 @@ var (
EnvVars: PrefixEnvVar("ETHERSCAN_API_KEY"),
Required: true,
}
EtherscanUrlFlag = &cli.StringFlag{
Name: EtherscanUrlFlagName,
Usage: "etherscan API URL for contract verification. when empty, default URLs are used.",
EnvVars: PrefixEnvVar("ETHERSCAN_API_URL"),
Required: false,
}
InputFileFlag = &cli.StringFlag{
Name: InputFileFlagName,
Usage: "filepath of input file for command",
Expand Down Expand Up @@ -143,6 +150,7 @@ var VerifyFlags = []cli.Flag{
L1RPCURLFlag,
ArtifactsLocatorFlag,
EtherscanAPIKeyFlag,
EtherscanUrlFlag,
InputFileFlag,
ContractNameFlag,
}
Expand Down
18 changes: 12 additions & 6 deletions op-deployer/pkg/deployer/verify/verifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,17 @@ type Verifier struct {
numFailed int
}

func NewVerifier(apiKey string, l1ChainID uint64, artifactsFS foundry.StatDirFs, l log.Logger, l1Client *ethclient.Client) (*Verifier, error) {
etherscanUrl, err := getAPIEndpoint(l1ChainID)
if err != nil {
return nil, fmt.Errorf("unsupported L1 chain ID: %d", l1ChainID)
func NewVerifier(apiKey string, l1ChainID uint64, artifactsFS foundry.StatDirFs, l log.Logger, l1Client *ethclient.Client, etherscanUrl string) (*Verifier, error) {
if len(etherscanUrl) == 0 {
var err error
etherscanUrl, err = getAPIEndpoint(l1ChainID)
if err != nil {
return nil, fmt.Errorf("unsupported L1 chain ID: %d", l1ChainID)
}
l.Info("found etherscan url", "url", etherscanUrl)
} else {
l.Info("using provided etherscan url", "url", etherscanUrl)
}
l.Info("found etherscan url", "url", etherscanUrl)

etherscan := NewEtherscanClient(apiKey, etherscanUrl, rate.NewLimiter(rate.Limit(1), 1))

Expand Down Expand Up @@ -94,7 +99,8 @@ func VerifyCLI(cliCtx *cli.Context) error {
}
l.Info("Downloaded artifacts", "path", artifactsFS)

v, err := NewVerifier(etherscanAPIKey, l1ChainId, artifactsFS, l, l1Client)
etherscanUrl := cliCtx.String(deployer.EtherscanUrlFlagName)
v, err := NewVerifier(etherscanAPIKey, l1ChainId, artifactsFS, l, l1Client, etherscanUrl)
if err != nil {
return fmt.Errorf("failed to create verifier: %w", err)
}
Expand Down