feat(op-deployer): customize etherscan URL from CLI and environment #17674
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbertov
force-pushed
the
feat/op-deployer/etherscan-url
branch
from
f263b20 to
60d8bb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR edits
op-deployercode, adding the capability to chose a custom Etherscan API URL, either using the--etherscan-urlCLI argument, or theETHERSCAN_API_URLenvironment variable.The new argument is optional and when empty, the behavior of chosing a default block explorer is preserved.
Tests
Found no pre-existing tests for
NewVerifieror any other component ofverifier.go. Let me know if this in particular should be tested.Additional context
Being able to verify source code for a local devnet deployment is very useful. Found no way to do so in the documentation and this seems like the easiest option. Let me know if I missed some doc article which mentions it.
Metadata