Privacy icon animation with tracker entities #222
Conversation
…+ Caches for animations and animation views implemented.
There was a problem hiding this comment.
Pretty much impossible to review in the browser (even tried Safari just to check it). Had to copy paste this comment.
I scanned the code using git log and nothing jumped out.
It seems to work but:
1/ the timing appears to be off - it's quite fast and you can't really see the icons.
2/ If you click on the dashboard before the animation starts, the dashboard closes (presumable the because the icon is being hidden).
However, I'm going to approve it because it's blocking me and it's difficult to review, we can follow up with another PR later.
|
Thank you Brindy! I'm sorry for fat PR. You can also review in Xcode but agree it isn't ideal when reviewer needs to comment a specific part of the code. 1/ Agree with you. Feel free to provide that feedback to Mary or Abe Thanks again! |
# By Tomas Strba (7) and others # Via GitHub * develop: FindTime URL problem corrected (#224) Privacy icon animation with tracker entities (#222) Fix test and animation on Tab removal (#223) SwiftLint warnings fixed Version 0.16.0 Fix Pinch-to-zoom (#221) Alex/downloads UI (#213) Allow single quote to be used with find in page query (#219) respect burner tab on page new tab (#218) only allow abritrary loads in web content and also use secure coding (#216) BSK update and email protection landing page URL change (#217) Version 0.15.4 remove tabBarViewItemMenu; minor warning cleanup (#209) Rename schemes, update README.md (#210) Active waiting instead of deadlock when loading persistent store (#214) Fire button UX enhancements (#212) burner tabs (#211) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
# By Alexey Martemyanov (31) and others # Via Tomas Strba * develop: (76 commits) Version 0.16.1 Quickfixes: Filtering removed downloads from the list corrected. Separator hiding when no download item is selected fixed. Download Manager - Product Review (#226) Use latest find in page (#227) quick design fixes (#225) Enable integration and UI test builds (#220) FindTime URL problem corrected (#224) Privacy icon animation with tracker entities (#222) Fix test and animation on Tab removal (#223) SwiftLint warnings fixed Version 0.16.0 Fix Pinch-to-zoom (#221) Alex/downloads UI (#213) Allow single quote to be used with find in page query (#219) respect burner tab on page new tab (#218) only allow abritrary loads in web content and also use secure coding (#216) BSK update and email protection landing page URL change (#217) Version 0.15.4 remove tabBarViewItemMenu; minor warning cleanup (#209) Rename schemes, update README.md (#210) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Menus/MainMenuActions.swift
Task/Issue URL: https://app.asana.com/0/0/1200885599483230/f
Description:
Note: Review will be a bit hard because of too many changes in Assets. Sorry about that. 🙏
The PR contains the next iteration of changes in privacy icon animation. PNG sequences were replaced with Lottie animation files. Tracker animation contains starting letters of tracking entities.
Steps to test this PR:
Testing checklist:
Test with Release configuration is not necessary
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM