This repository was archived by the owner on Feb 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I bashed on this a bunch and wasn't able to find any issues with it. Tested tab functionality, state restoration, keyboard shortcuts, menu items etc., all looks good. 👏
samsymons
added a commit
that referenced
this pull request
Sep 24, 2021
# By Tomas Strba (7) and others # Via GitHub * develop: FindTime URL problem corrected (#224) Privacy icon animation with tracker entities (#222) Fix test and animation on Tab removal (#223) SwiftLint warnings fixed Version 0.16.0 Fix Pinch-to-zoom (#221) Alex/downloads UI (#213) Allow single quote to be used with find in page query (#219) respect burner tab on page new tab (#218) only allow abritrary loads in web content and also use secure coding (#216) BSK update and email protection landing page URL change (#217) Version 0.15.4 remove tabBarViewItemMenu; minor warning cleanup (#209) Rename schemes, update README.md (#210) Active waiting instead of deadlock when loading persistent store (#214) Fire button UX enhancements (#212) burner tabs (#211) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1200889822261518
Tech Design URL:
CC:
Description:
We created a new design that allowed burner tabs to live along side others. I figure we can let people play with it in real life and get feedback, it'll be easy enough to remove.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM