Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

burner tabs #211

Merged
merged 12 commits into from
Sep 9, 2021
Merged

burner tabs #211

merged 12 commits into from
Sep 9, 2021

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Sep 6, 2021

Task/Issue URL: https://app.asana.com/0/392891325557410/1200889822261518
Tech Design URL:
CC:

Description:

We created a new design that allowed burner tabs to live along side others. I figure we can let people play with it in real life and get feedback, it'll be easy enough to remove.

Steps to test this PR:

  1. Check the 'plus button' for a new tab works as normal
  2. Long press the plus button for a popover menu, and choose new burner tab
  3. Cmd-Shift T should open a new burner tab
  4. Check that burner tab URLs don't get stored in the URL and the data isn't cached
  5. Check menus close / open burner tabs as expected

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy changed the title burner tabs (WIP) burner tabs Sep 6, 2021
@samsymons samsymons self-assigned this Sep 8, 2021
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I bashed on this a bunch and wasn't able to find any issues with it. Tested tab functionality, state restoration, keyboard shortcuts, menu items etc., all looks good. 👏

@brindy brindy merged commit df06741 into develop Sep 9, 2021
@brindy brindy deleted the brindy/hack-days-fire-tab branch September 9, 2021 09:55
samsymons added a commit that referenced this pull request Sep 24, 2021
# By Tomas Strba (7) and others
# Via GitHub
* develop:
  FindTime URL problem corrected (#224)
  Privacy icon animation with tracker entities (#222)
  Fix test and animation on Tab removal (#223)
  SwiftLint warnings fixed
  Version 0.16.0
  Fix Pinch-to-zoom (#221)
  Alex/downloads UI (#213)
  Allow single quote to be used with find in page query (#219)
  respect burner tab on page new tab (#218)
  only allow abritrary loads in web content and also use secure coding (#216)
  BSK update and email protection landing page URL change (#217)
  Version 0.15.4
  remove tabBarViewItemMenu; minor warning cleanup (#209)
  Rename schemes, update README.md (#210)
  Active waiting instead of deadlock when loading persistent store (#214)
  Fire button UX enhancements (#212)
  burner tabs (#211)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants