skpkg: Add config files & project.toml #26
Conversation
zmx27
left a comment
zmx27
left a comment
There was a problem hiding this comment.
See comments.
P.S. I see that you are repeating some files that you already have on other PRs(ex: #22), such as .isort and .flake8, etc. I'm not completely sure, but I think this is fine for GitHub as these new files you're adding seem to be identical. But in the future, please avoid doing this.
| @@ -0,0 +1,18 @@ | |||
| name: Release (GitHub/PyPI) and Deploy Docs | |||
There was a problem hiding this comment.
We will probably need Professor Simon to review this file. I know that this package won't get released using the workflow script it's currently calling since this is a private repo, but I'm also not sure what the exact process will be
|
|
||
| jobs: | ||
| matrix-coverage: | ||
| uses: scikit-package/release-scripts/.github/workflows/_matrix-and-codecov-on-merge-to-main.yml@v0 |
There was a problem hiding this comment.
This repo will need to call a different workflow file. I think it's something like
_matrix-no-codecov-on-merge-to-main.yml? Please double check.
There was a problem hiding this comment.
correct @zmx27. Please check in the the diffpy.pdfgetx repo.
| c_extension: false | ||
| headless: false | ||
| secrets: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
|
@sbillinge Professor Simon, could you help Zhiming and me to figure it out what do we need to do with the workflow for the |
please uses the |
|
@zmx27 Could you share the template for workflow for |
|
@stevenhua0320 separately copying each of the workflow files from |
|
@zmx27 I could not see it since it is a private repo, and Professor Simon did not give me the access to see it. @sbillinge Is it possible to share the access of |
ok, done |
|
|
||
| jobs: | ||
| matrix-coverage: | ||
| uses: scikit-package/release-scripts/.github/workflows/_matrix-and-codecov-on-merge-to-main.yml@v0 |
There was a problem hiding this comment.
correct @zmx27. Please check in the the diffpy.pdfgetx repo.
|
@stevenhua0320 this also failed pre-commit on CI. Make sure you are running p-c locally on all files, but you will have to merge origin with you local before making edits, and repush to avoid conflicts. |
|
@sbillinge Ready for review as p-c now passed and have edited the workflow. |
zmx27
left a comment
zmx27
left a comment
There was a problem hiding this comment.
@stevenhua0320 This looks good, but you also need to adapt the release-github.yml file from the pdfgetx repo. The current build-wheel-release-upload.yml file will be calling that
| @@ -0,0 +1,12 @@ | |||
| name: Deploy Documentation on Release | |||
There was a problem hiding this comment.
I don't think we need this file if we don't plan on having docs built
|
@zmx27 Ready for another review |
3 participants
@zmx27 Ready to review