Skip to content

Conversation

@stevenhua0320
Copy link
Contributor

@zmx27 Ready for review

Copy link
Collaborator

@zmx27 zmx27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise looks good to me

.idea/.gitignore Outdated
@@ -0,0 +1,8 @@
# Default ignored files
Copy link
Collaborator

@zmx27 zmx27 Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for? I'm assuming it's the file generated by the Intellij IDE, but I don't think we need this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since it starts with .idea, I would drop this in new commit

@stevenhua0320
Copy link
Contributor Author

@sbillinge Ready for review

@sbillinge sbillinge merged commit 93dc9db into diffpy:migration Oct 7, 2025
@sbillinge sbillinge deleted the pre-commit-auto branch October 7, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants