Improve cross platform compliance #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akeLists.txt The option deceleration is missing, yet it is used for setting up the `stdlib=stdc++` flag for clang. Cmake option has the default value of `OFF`; the value is negated in the if statement so by default the flag is appended regardless of whether the machine has `stdc++` installed. Since some Clang installations do not come with `stdc++`, the project cannot be built. The default value is set to `ON` since LLVM's implementation of C++17 is not yet complete. More can be found in the links below: - [cppreference](https://en.cppreference.com/w/cpp/compiler_support) - [libc++ on 17](https://libcxx.llvm.org/cxx1z_status.html) - [libc++ homepage](https://libcxx.llvm.org/index.html)
By default if `CMAKE_CXX_EXTENSIONS` and `CMAKE_CXX_STANDARD_REQUIRED` are not set, cmake would allow non-standard C++ extensions. For instance it would pass `-std=gnu++17` instead of `-std=c++17` to GCC.
Author
|
Also, I would suggest making option wording positive. I.e. "build with LLVM lib" instead of "disable build with LLVM lib", since CMake options are OFF by default. |
Internal-Compiler-Error
changed the title
Member
|
I am happy with the changes you made, but I can't merge while the Travis build is failing. Normally, this shouldn't be difficult to apply but I have no time to look at this. How quickly do you need this integrated? Would you be able to take a look at the .travis.yml file yourself? Thanks for the report and the interest in the library. |
glynos
approved these changes
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top-level
CMakeLists.txtmakes clang installations withoutstdc++impossible to compile. It also allows non-standard C++. More can be found in the commit messages.