Commit 7139727
Improve cross platform compliance (#32)
* Add missing `Skyr_DISABLE_LIBCXX` option deceleration in top level CMakeLists.txt
The option deceleration is missing, yet it is used for setting up the
`stdlib=stdc++` flag for clang. Cmake option has the default value of `OFF`;
the value is negated in the if statement so by default the flag is appended
regardless of whether the machine has `stdc++` installed. Since some Clang
installations do not come with `stdc++`, the project cannot be built.
The default value is set to `ON` since LLVM's implementation of C++17 is not
yet complete. More can be found in the links below:
- [cppreference](https://en.cppreference.com/w/cpp/compiler_support)
- [libc++ on 17](https://libcxx.llvm.org/cxx1z_status.html)
- [libc++ homepage](https://libcxx.llvm.org/index.html)
* Improve standard compliance
By default if `CMAKE_CXX_EXTENSIONS` and `CMAKE_CXX_STANDARD_REQUIRED`
are not set, cmake would allow non-standard C++ extensions. For instance
it would pass `-std=gnu++17` instead of `-std=c++17` to GCC.1 parent a198433 commit 7139727
1 file changed
+3
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
0 commit comments