Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): Remove sdk-node references and dependencies #4861

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Jan 9, 2025

Description

We've reached the end of the support period for @clerk/clerk-sdk-node. This PR removes all references to the deprecated SDK from our monorepo, which has been moved to this repository.

For Node integration, Express applications can use @clerk/express, while other Node projects should use @clerk/backend.

I'll ping whoever can mark the npm package as deprecated 🫡

Related:

Resolves ECO-293

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 5:10pm

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 3fbc9cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wobsoriano wobsoriano changed the title chore(sdk-node): Clear all Node SDK references and dependencies chore: Clear all sdk-node references and dependencies Jan 9, 2025
@wobsoriano wobsoriano changed the title chore: Clear all sdk-node references and dependencies chore: Remove all sdk-node references and dependencies Jan 9, 2025
@wobsoriano wobsoriano changed the title chore: Remove all sdk-node references and dependencies chore(repo): Remove all sdk-node references and dependencies Jan 9, 2025
@wobsoriano wobsoriano changed the title chore(repo): Remove all sdk-node references and dependencies chore(repo): Remove sdk-node references and dependencies Jan 9, 2025
@wobsoriano wobsoriano marked this pull request as ready for review January 9, 2025 20:54
@wobsoriano wobsoriano requested review from LekoArts and octoper January 9, 2025 20:54
Copy link
Member

@jacekradko jacekradko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-10 at 11 20 20 AM

❤️

@wobsoriano wobsoriano merged commit 04276fe into main Jan 10, 2025
30 checks passed
@wobsoriano wobsoriano deleted the rob/eco-293-remove-clerk-sdk-node-package-and-e2e-tests-from-the-js branch January 10, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants