Skip to content

Commit 04276fe

Browse files
authored
chore(repo): Remove sdk-node references and dependencies (#4861)
1 parent b18307c commit 04276fe

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+180
-3949
lines changed

.changeset/ten-tools-exist.md

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

.github/labeler.yml

-3
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ react-router:
4242
remix:
4343
- packages/remix/**
4444

45-
sdk-node:
46-
- packages/sdk-node/**
47-
4845
tanstack:
4946
- packages/tanstack-start/**
5047

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ jobs:
134134
run: |
135135
if [ "${{ matrix.node-version }}" == "18" ]; then
136136
echo "Running tests on Node 18 only for packages with LTS support."
137-
pnpm turbo test $TURBO_ARGS --filter="@clerk/astro" --filter="@clerk/backend" --filter="@clerk/express" --filter="@clerk/nextjs" --filter="@clerk/clerk-react" --filter="@clerk/clerk-sdk-node" --filter="@clerk/shared" --filter="@clerk/remix" --filter="@clerk/tanstack-start" --filter="@clerk/elements" --filter="@clerk/vue" --filter="@clerk/nuxt" --filter="@clerk/clerk-expo"
137+
pnpm turbo test $TURBO_ARGS --filter="@clerk/astro" --filter="@clerk/backend" --filter="@clerk/express" --filter="@clerk/nextjs" --filter="@clerk/clerk-react" --filter="@clerk/shared" --filter="@clerk/remix" --filter="@clerk/tanstack-start" --filter="@clerk/elements" --filter="@clerk/vue" --filter="@clerk/nuxt" --filter="@clerk/clerk-expo"
138138
else
139139
echo "Running tests for all packages on Node 22."
140140
pnpm turbo test $TURBO_ARGS

.jit/config.yml

-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ folders:
2121
- path: /packages/remix
2222
exclude:
2323
- ./**/*.test.ts
24-
- path: /packages/sdk-node
25-
exclude:
26-
- ./**/*.test.ts
2724
- path: /packages/shared
2825
exclude:
2926
- ./**/*.test.ts

.prettierignore

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ coverage
1414
coverage
1515
dist
1616
/packages/nextjs/examples
17-
/packages/sdk-node/examples
1817
node_modules
1918
package-lock.json
2019
pnpm-lock.yaml

integration/presets/express.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@ import { linkPackage } from './utils';
66
const vite = applicationConfig()
77
.setName('express-vite')
88
.useTemplate(templates['express-vite'])
9-
.setEnvFormatter('public', key => `VITE_${key}`)
109
.addScript('setup', 'pnpm install')
1110
.addScript('dev', 'pnpm dev')
1211
.addScript('build', 'pnpm build')
1312
.addScript('serve', 'pnpm start')
14-
.addDependency('@clerk/clerk-sdk-node', constants.E2E_CLERK_VERSION || linkPackage('sdk-node'));
13+
.addDependency('@clerk/express', constants.E2E_CLERK_VERSION || linkPackage('express'));
1514

1615
export const express = {
1716
vite,

integration/templates/express-vite/package.json

+5-6
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,16 @@
1010
"start": "PORT=$PORT ts-node src/server/main.ts"
1111
},
1212
"dependencies": {
13-
"dotenv": "^16.3.1",
13+
"dotenv": "^16.4.7",
1414
"ejs": "^3.1.6",
1515
"express": "^4.18.2",
1616
"ts-node": "^10.9.1",
17-
"typescript": "^5.6.3",
18-
"vite-express": "^0.11.0"
17+
"vite-express": "^0.20.0"
1918
},
2019
"devDependencies": {
2120
"@types/express": "^4.17.21",
22-
"@types/node": "^18.19.33",
23-
"nodemon": "^2.0.22",
24-
"vite": "^4.0.4"
21+
"@types/node": "^20.9.3",
22+
"typescript": "^5.6.3",
23+
"vite": "^5.0.2"
2524
}
2625
}

integration/templates/express-vite/src/server/main.ts

+17-9
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,52 @@
11
// Should be at the top of the file - used to load clerk secret key
2-
import * as dotenv from 'dotenv';
3-
dotenv.config();
2+
import 'dotenv/config';
43

5-
import { clerkClient } from '@clerk/clerk-sdk-node';
4+
import { clerkMiddleware } from '@clerk/express';
65
import express from 'express';
76
import ViteExpress from 'vite-express';
87

98
const app = express();
109

10+
app.use(clerkMiddleware());
1111
app.set('view engine', 'ejs');
1212
app.set('views', 'src/views');
1313

14-
app.get('/api/protected', [clerkClient.expressRequireAuth() as any], (_req: any, res: any) => {
15-
res.send('Protected API response').end();
14+
const legacyRequireAuth = (req: any, _res: any, next: any) => {
15+
if (!req.auth.userId) {
16+
return next(new Error('Unauthenticated'));
17+
}
18+
19+
next();
20+
};
21+
22+
app.get('/api/protected', legacyRequireAuth, (_req: any, res: any, _next: any) => {
23+
return res.send('Protected API response');
1624
});
1725

1826
app.get('/sign-in', (_req: any, res: any) => {
1927
return res.render('sign-in.ejs', {
20-
publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY,
28+
publishableKey: process.env.CLERK_PUBLISHABLE_KEY,
2129
signInUrl: process.env.CLERK_SIGN_IN_URL,
2230
});
2331
});
2432

2533
app.get('/', (_req: any, res: any) => {
2634
return res.render('index.ejs', {
27-
publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY,
35+
publishableKey: process.env.CLERK_PUBLISHABLE_KEY,
2836
signInUrl: process.env.CLERK_SIGN_IN_URL,
2937
});
3038
});
3139

3240
app.get('/sign-up', (_req: any, res: any) => {
3341
return res.render('sign-up.ejs', {
34-
publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY,
42+
publishableKey: process.env.CLERK_PUBLISHABLE_KEY,
3543
signUpUrl: process.env.CLERK_SIGN_UP_URL,
3644
});
3745
});
3846

3947
app.get('/protected', (_req: any, res: any) => {
4048
return res.render('protected.ejs', {
41-
publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY,
49+
publishableKey: process.env.CLERK_PUBLISHABLE_KEY,
4250
signInUrl: process.env.CLERK_SIGN_IN_URL,
4351
signUpUrl: process.env.CLERK_SIGN_UP_URL,
4452
});

packages/sdk-node/.eslintrc.js

-4
This file was deleted.

packages/sdk-node/.gitignore

-8
This file was deleted.

packages/sdk-node/.npmignore

-3
This file was deleted.

0 commit comments

Comments
 (0)