No longer block reading from the request body until the buffer is fil… #4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led for a PUT operation in the AWS CRT-based S3 client
zoewangg
force-pushed
the
zoewang/s3crt-notBlocking
branch
from
e757a0b to
ff741db
Compare
zoewangg
commented
Aug 31, 2023
|
|
||
| // blocking here because CRT S3 requires the buffer to be completely filled | ||
| return requestBodySubscriber.blockingTransferTo(outBuffer) == ByteBufferStoringSubscriber.TransferResult.END_OF_STREAM; | ||
| return requestBodySubscriber.transferTo(outBuffer) == ByteBufferStoringSubscriber.TransferResult.END_OF_STREAM; |
There was a problem hiding this comment.
Integ tests and stability tests passed
|
Kudos, SonarCloud Quality Gate passed! |
cenedhryn
approved these changes
Sep 1, 2023
aws-sdk-java-automation
added a commit
that referenced
this pull request
Sep 18, 2025
…9b8407500 Pull request: release <- staging/995c1288-a6cb-4871-8530-d579b8407500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…led for a PUT operation in the AWS CRT-based S3 client
Motivation and Context
#4305
CRT has made a fix to lift the requirement of buffer being completely filled.
Modifications
Updated the request body adapter to not block the read until the byte buffer is filled
Testing
Running existing tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License