No longer block reading from the request body until the buffer is filled for a PUT operation in the AWS CRT-based S3 client (#4308)

zoewangg · web-flow · commit d25332d8bd0b · 2023-09-08T09:57:06.000-07:00
diff --git a/services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtRequestBodyStreamAdapter.java b/services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtRequestBodyStreamAdapter.java
@@ -44,8 +44,7 @@ public boolean sendRequestBody(ByteBuffer outBuffer) {
             bodyPublisher.subscribe(requestBodySubscriber);
         }
 
-        // blocking here because CRT S3 requires the buffer to be completely filled
-        return requestBodySubscriber.blockingTransferTo(outBuffer) == ByteBufferStoringSubscriber.TransferResult.END_OF_STREAM;
+        return requestBodySubscriber.transferTo(outBuffer) == ByteBufferStoringSubscriber.TransferResult.END_OF_STREAM;
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,7 @@ public boolean sendRequestBody(ByteBuffer outBuffer) {`
`44`	`44`	`bodyPublisher.subscribe(requestBodySubscriber);`
`45`	`45`	`}`
`46`	`46`
`47`		`- // blocking here because CRT S3 requires the buffer to be completely filled`
`48`		`- return requestBodySubscriber.blockingTransferTo(outBuffer) == ByteBufferStoringSubscriber.TransferResult.END_OF_STREAM;`
	`47`	`+ return requestBodySubscriber.transferTo(outBuffer) == ByteBufferStoringSubscriber.TransferResult.END_OF_STREAM;`
`49`	`48`	`}`
`50`	`49`
`51`	`50`	`@Override`