Check new URL on modification PRs #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
github-actions
bot
added
other
and removed
topic: code
Contributor
|
Hi @per1234. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
silvanocerza
approved these changes
Apr 30, 2021
The "modify" request type is when the PR does removals as well as additions to the list. The valid reason for doing this would be changing the URL of a library after the repo is renamed or the library moved to another repo. This request type requires a manual review and merge, but the new URLs should be automatically processed to save the reviewer from having to check it and work with the library submitter to resolve any issues that are found. In this case, the `arduino/arduino-lint-action`'s `library-manager` input needs to be set to "update" instead of the previously hardcoded "submit". The correct setting will be provided by the parser, so the workflow only needs to implement the use of that setting.
per1234
force-pushed
the
check-modifications
branch
from
c15b093 to
66d13b0
Compare
Contributor
|
Hi @per1234. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "modify" request type is when the PR does removals as well as additions to the list. The valid reason for doing this
would be changing the URL of a library after the repo is renamed or the library moved to another repo.
This request type requires a manual review and merge, but the new URLs should be automatically processed to save the
reviewer from having to check it and work with the library submitter to resolve any issues that are found.
In this case, the
arduino/arduino-lint-action'slibrary-managerinput needs to be set to "update" instead of thepreviously hardcoded "submit". The correct setting will be provided by the parser, so the workflow only needs to
implement the use of that setting.
This is dependent on arduino/library-registry-submission-parser#26
Demo: per1234#44