Output appropriate arduino-lint --library-manager setting
#26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a submission URL is modified, it must also be checked. In this case, the `arduino/arduino-lint-action`'s `library-manager` input setting must be "update" instead of "submit", since the library is already in the index. Since, manual testing of GitHub Actions workflows is not well supported, it's best to keep as much of the logic as possible in the Go code of the parser. For this reason, the parser should determine the appropriate `library-manager` setting and pass that to the workflow.
per1234
added
type: enhancement
silvanocerza
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a submission URL is modified, it must also be checked. In this case, the
arduino/arduino-lint-action'slibrary-managerinput setting must be "update" instead of "submit", since the library is already in the index.Since, automated testing of GitHub Actions workflows is not well supported, it's best to keep as much of the logic as
possible in the Go code of the parser. For this reason, the parser should determine the appropriate
library-managersetting and pass that to the workflow.
Demo: per1234/library-registry#44