-
-
Notifications
You must be signed in to change notification settings - Fork 439
Portenta H7 tutorial: Secure Boot [PC-894] #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ubi de Feo <me@ubidefeo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pennam you need to change your review to an approve one for us to move forward with the approval of the article. @karlsoderby please review from a content perspective! Thanks! |
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content LGTM, just fixed some typos or formatting issues.
Thank you!
I will add some screenshot to show the new selector on the dropdown for using the keys.
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Pablo Marquínez Ferrándiz <pablomarqfer@gmail.com>
@umbynos Is it compatible with the lite and lite-connected? (i guess it isnt as they dont have the crypto chip, if im not wrong 🤔) |
Also this link is dead right now |
You are right, the link will be working when the new release of the |
@marqdevx yes, they will be supported because by default MCUboot does not rely on any hw crypto. There is the possibility to implement signature verification and encryption key unwrapping using a crypto but this is not done yet, all the crypto magic is done by software with mbedtls. |
Perfect! Thanks for the aclaration. Just made this tutorial available on lite and lite-connected aswell at 49c15cf For the link should we wait to have the published one before merging this tutorial? If you want to merge it now, we just need to hide it until the link works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff @umbynos ! Please have a look at my suggestions and questions.
Also, I think it would be very beneficial to add a paragraph in the Introduction section explaining the use case for secure boot. Why would anyone want to use it? Intellectual property protection? Tamper proof? ...
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Show resolved
Hide resolved
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Romero <s.romero.zh@gmail.com>
@umbynos Let me know if you need anything to continue with this merge :D |
@marqdevx I think with a final review by @sebromero we are good to go. |
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this and we're good to go.
content/hardware/04.pro/boards/portenta-h7/tutorials/secure-boot/secure-boot.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pennam Please have a final look. If you're good with it, we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[TC-257] Remove mention of J19 in DS and assets for Max Carrier
What This PR Changes
What Needs To Be Reviewed
How To Give Feedback
Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏