-
-
Notifications
You must be signed in to change notification settings - Fork 401
Add keys generate command #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
type TempFileCreationFailedError struct { | ||
Cause error | ||
// FileCreationFailedError is returned if a temp file could not be created | ||
type FileCreationFailedError struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is an exported object, this will be a breaking change and so the standard procedure should be followed to communicate that to the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not though about it, but you are right
Co-authored-by: per1234 <accounts@perglass.com>
e55e6ac
to
0ff01b7
Compare
In the end, we decided to keep it simple and do not add key generation to the arduino-cli. We decided instead to write a guide on how to do it using imgtool (along with download links to it). This was a difficult decision, but the reasons in favor of the guide were multiple:
Things could change in the future. If/When there will be other boards supporting secure-boot maybe this topic will be faced again. But we would have users with clear requirements, and we could better develop this |
Guide here arduino/docs-content#129 |
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)feature
add
keys generate
command to generate the encryption keys required for secure boottitled accordingly?
See how to contribute