Skip to content

Use workflow variables for tool versions in all workflows #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/check-code-generation-task.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Check Code Generation

env:
# See: https://github.com/actions/setup-go/tree/v2#readme
GO_VERSION: "1.16"

on:
push:
paths:
Expand All @@ -18,9 +22,6 @@ on:
- "**/*.go"
- "etc/schemas/**/*.json"

env:
BUILDS_ARTIFACT: build-artifacts

jobs:
test-go:
runs-on: ubuntu-latest
Expand All @@ -32,7 +33,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: "1.16"
go-version: ${{ env.GO_VERSION }}

- name: Install Taskfile
uses: arduino/setup-task@v1
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/deploy-cobra-mkdocs-versioned-poetry.md
name: Deploy Website

env:
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
PYTHON_VERSION: "3.9"

on:
push:
branches:
Expand Down Expand Up @@ -52,7 +56,7 @@ jobs:
- name: Install Python
uses: actions/setup-python@v2
with:
python-version: "3.9"
python-version: ${{ env.PYTHON_VERSION }}

- name: Install Poetry
run: |
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/spell-check-task.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/spell-check-task.md
name: Spell Check

env:
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
PYTHON_VERSION: "3.9"

# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
on:
push:
Expand All @@ -22,7 +26,7 @@ jobs:
- name: Install Python
uses: actions/setup-python@v2
with:
python-version: "3.9"
python-version: ${{ env.PYTHON_VERSION }}

- name: Install Poetry
run: pip install poetry
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/test-go-integration-task.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
name: Test Integration

env:
# See: https://github.com/actions/setup-go/tree/v2#readme
GO_VERSION: "1.16"
# See: https://github.com/actions/setup-python/tree/v2#available-versions-of-python
PYTHON_VERSION: "3.9"

on:
push:
paths:
Expand Down Expand Up @@ -40,7 +46,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: "1.16"
go-version: ${{ env.GO_VERSION }}

- name: Install Taskfile
uses: arduino/setup-task@v1
Expand All @@ -51,7 +57,7 @@ jobs:
- name: Install Python
uses: actions/setup-python@v2
with:
python-version: "3.9"
python-version: ${{ env.PYTHON_VERSION }}

- name: Install Poetry
run: pip install poetry
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/test-go-task.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Run tests

env:
# See: https://github.com/actions/setup-go/tree/v2#readme
GO_VERSION: "1.16"

on:
push:
paths:
Expand All @@ -18,9 +22,6 @@ on:
- "**/*.go"
- "**/testdata/**"

env:
BUILDS_ARTIFACT: build-artifacts

jobs:
test-go:
strategy:
Expand All @@ -39,7 +40,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: "1.16"
go-version: ${{ env.GO_VERSION }}

- name: Install Taskfile
uses: arduino/setup-task@v1
Expand Down