Use workflow variables for tool versions in all workflows #237
+28
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were artifacts left over from when the test workflow also generated the tester builds, but that process been moved to a dedicated workflow.
Placement of this information at the top of the file, where it is easy to find and edit, facilitates updates to the workflows as the tool version used for project development are bumped periodically. This is an established convention in the "template" workflows, but I missed some applications of it. I think it's most effective when done consistently throughout the workflows.
per1234
added
type: enhancement
umbynos
approved these changes
Aug 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 88.67% 88.67%
=======================================
Files 43 43
Lines 4143 4143
=======================================
Hits 3674 3674
Misses 358 358
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placement of this information at the top of the file, where it is easy to find and edit, facilitates updates to the
workflows as the tool version used for project development are bumped periodically.
This is an established convention in the "template" workflows, but I missed some applications of it. I think it's most
effective when done consistently throughout the workflows.